Validation to disallow multiple create on related entities backed by same database table #2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayush3797
requested review from
Aniruddh25,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
gledis69,
mbhaskar,
neeraj-sharma2592,
ravishetye,
rohkhann,
seantleonard,
severussundar,
sourabh1007 and
tarazou9
as code owners
…tionshipForMutations
ayush3797
added
the
Multiple mutations
Contributor
Author
|
/azp run |
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
are tests dependent on #2138
Contributor
Author
Are not dependent. But will require additional entities in the config and some more changes. Keeping bug-bash in mind, trying to get the logic changes in and test can follow. |
Contributor
Author
|
Now I'm onto adding test. |
Contributor
Author
|
/azp run |
Aniruddh25
reviewed
Apr 26, 2024
src/Service.Tests/Unittests/MultipleCreateUnitTests/MultipleCreateOrderHelperUnitTests.cs
Show resolved
Hide resolved
Aniruddh25
reviewed
Apr 26, 2024
src/Service.Tests/Unittests/MultipleCreateUnitTests/MultipleCreateOrderHelperUnitTests.cs
Show resolved
Hide resolved
Aniruddh25
reviewed
Apr 26, 2024
src/Service.Tests/Unittests/MultipleCreateUnitTests/MultipleCreateOrderHelperUnitTests.cs
Show resolved
Hide resolved
Aniruddh25
previously requested changes
Apr 26, 2024
Collaborator
Aniruddh25
left a comment
Aniruddh25
left a comment
There was a problem hiding this comment.
Waiting on safe typecast to DatabaseTable
seantleonard
requested changes
Apr 30, 2024
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
dont need isMNRelationship as a param to getreferencingEntityName otherwise looks good. As Ani mentioned, casting feedback needs addressing
seantleonard
approved these changes
Apr 30, 2024
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
need not block on my feedback, only Ani's. Go ahead and make those changes and you should be good from my end. Let me know if you think we really need to keep isMNRelationship param.
Co-authored-by: Aniruddh Munde <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
…eateOrderHelperUnitTests.cs Co-authored-by: Aniruddh Munde <[email protected]>
…eateOrderHelperUnitTests.cs Co-authored-by: Aniruddh Munde <[email protected]>
Co-authored-by: Aniruddh Munde <[email protected]>
ayush3797
changed the title
ayush3797
changed the title
Contributor
Author
|
/azp run |
abhishekkumams
approved these changes
May 1, 2024
Contributor
Author
|
/azp run |
…tionshipForMutations
Contributor
Author
|
/azp run |
…tionshipForMutations
Contributor
Author
|
/azp run |
ayush3797
deleted the
dev/agarwalayush/prohibitSelfReferencingRelationshipForMutations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
DAB doesn't support multiple-create on related entities which are backed by same database table. This PR adds a validation to catch that scenario and throw a meaningful exception to the end user. Issue to track support: #2157
What is this change?
MultipleCreateOrderHelper.GetReferencingEntityName()method to catch the scenario.MultipleCreateOrderHelper.GetReferencingEntityName(), a new parameter isMNRelationship is added with default value of false. The reasoning is explained in the section.Reason for why
MultipleCreateOrderHelper.GetReferencingEntityName()is called even for M:N relationships when we know that we are always going to return an empty string?MultipleCreateOrderHelper.GetReferencingEntityName()method.MultipleCreateOrderHelperprovides unit test coverage even for the other 2 db types i.e. PgSql,MySql.How was this tested?
Sample Request(s)
Request: